westonpace commented on code in PR #14024:
URL: https://github.com/apache/arrow/pull/14024#discussion_r967110525
##########
cpp/src/arrow/compute/exec/exec_plan.cc:
##########
@@ -643,6 +643,10 @@ Declaration Declaration::Sequence(std::vector<Declaration>
decls) {
return out;
}
+bool Declaration::IsValid(ExecFactoryRegistry* registry) const {
+ return registry->GetFactory(this->factory_name).ok() && this->options !=
nullptr;
Review Comment:
That's beyond the scope of this PR. What you have is probably all that
makes sense for the short term. Initially I would say, yes, it makes sense to
do more extensive validation. However, in practice, I'm not sure it's possible
to do without creating a plan and nodes from the declaration or requiring a
second validation function when registering factories.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
