thinkharderdev commented on code in PR #3470:
URL: https://github.com/apache/arrow-datafusion/pull/3470#discussion_r970645485
##########
datafusion/core/src/physical_plan/file_format/row_filter.rs:
##########
@@ -202,7 +202,18 @@ impl<'a> ExprRewriter for FilterCandidateBuilder<'a> {
fn mutate(&mut self, expr: Expr) -> Result<Expr> {
if let Expr::Column(Column { name, .. }) = &expr {
if self.file_schema.field_with_name(name).is_err() {
- return Ok(Expr::Literal(ScalarValue::Null));
+ // the column expr must be in the table schema
+ return match self.table_schema.field_with_name(name) {
Review Comment:
Something like
```
fn mutate(&mut self, expr: Expr) -> Result<Expr> {
match &expr {
Expr::BinaryExpr { left: Column { name, .. }, op, right } => {
if self.file_schema.field_with_name(name).is_err() {
return
Ok(Expr::Literal(ScalarValue::Boolean(Some(false)));
}
}
Expr::Column(Column { name, .. }) => {
if self.file_schema.field_with_name(name).is_err() {
return Ok(Expr::Literal(ScalarValue::Null));
}
}
_ => ()
}
Ok(expr)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
