askoa commented on issue #209: URL: https://github.com/apache/arrow-ballista/issues/209#issuecomment-1247178509
@yahoNanJing I looked into this and just wanted to clarify something. I might be wrong, but looks like the current proto definition allows to send multiple tasks in a single launch task. See line `#835` https://github.com/apache/arrow-ballista/blob/2e1f5d619760d3b7acce225a166a9507f9efe9a1/ballista/rust/core/proto/ballista.proto#L833-L837 However in the code, I see the tasks are launched one at a time. See line `#427` https://github.com/apache/arrow-ballista/blob/2e1f5d619760d3b7acce225a166a9507f9efe9a1/ballista/rust/scheduler/src/state/task_manager.rs#L425-L429 Can this task be simplified as modifying the [`for loop`](https://github.com/apache/arrow-ballista/blob/2e1f5d619760d3b7acce225a166a9507f9efe9a1/ballista/rust/scheduler/src/state/mod.rs#L198) in [`offer_reservation`](https://github.com/apache/arrow-ballista/blob/2e1f5d619760d3b7acce225a166a9507f9efe9a1/ballista/rust/scheduler/src/state/mod.rs#L188) function to group tasks be `executor_id` and send them in a single `launch_task`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
