liukun4515 commented on code in PR #3485:
URL: https://github.com/apache/arrow-datafusion/pull/3485#discussion_r971412997
##########
datafusion/core/src/config.rs:
##########
@@ -102,6 +105,20 @@ impl ConfigDefinition {
ScalarValue::UInt64(Some(default_value)),
)
}
+
+ /// Create a configuration option definition with a string value
+ pub fn new_string(
+ key: impl Into<String>,
+ description: impl Into<String>,
+ default_value: String,
+ ) -> Self {
+ Self::new(
+ key,
+ description,
+ DataType::UInt64,
Review Comment:
```suggestion
DataType::Utf8,
```
I think the data type should be UTF8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
