waitingkuo commented on code in PR #3485:
URL: https://github.com/apache/arrow-datafusion/pull/3485#discussion_r971207284
##########
datafusion/sql/src/planner.rs:
##########
@@ -2386,8 +2386,14 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
));
}
- let query = if variable.to_lowercase() == "all" {
+ let variable_lower = variable.to_lowercase();
+ println!("{}", variable_lower);
+
+ let query = if variable_lower == "all" {
String::from("SELECT name, setting FROM
information_schema.df_settings")
+ } else if variable_lower == "timezone" || variable_lower ==
"time.zone" {
+ // we could introduce alias in OptionDefinition if this string
matching thing grows
+ String::from("SELECT name, setting FROM
information_schema.df_settings WHERE name = 'datafusion.execution.time_zone'")
Review Comment:
if we have more and more alias like this, we could consider add aliases into
`ConfigDefinition`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
