rok commented on code in PR #14106:
URL: https://github.com/apache/arrow/pull/14106#discussion_r972984461
##########
cpp/src/arrow/compute/kernels/scalar_cast_numeric.cc:
##########
@@ -769,6 +770,36 @@ std::vector<std::shared_ptr<CastFunction>>
GetNumericCasts() {
return functions;
}
+
+Status CastToExtension(KernelContext* ctx, const ExecSpan& batch, ExecResult*
out) {
+ const CastOptions& options = checked_cast<const
CastState*>(ctx->state())->options;
+ DCHECK(batch[0].is_array());
+ std::shared_ptr<Array> array = batch[0].array.ToArray();
+ std::shared_ptr<Array> result;
+
+ auto out_ty = GetExtensionType("arrow.py_integer_type")->storage_type();
+ RETURN_NOT_OK(Cast(*array, out_ty, options,
+ ctx->exec_context())
+ .Value(&result));
+
+ ExtensionArray extension(options.to_type.GetSharedPtr(), result);
+ out->value = std::move(extension.data());
+ return Status::OK();
+}
Review Comment:
This seems ok and slick-er way can wait.
I'm wondering if this passes enough information about the type. Namely would
it work for [parametric extension
types](https://github.com/apache/arrow/blob/master/cpp/src/arrow/extension_type_test.cc#L302).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
