thinkharderdev opened a new pull request, #3574:
URL: https://github.com/apache/arrow-datafusion/pull/3574
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #3555
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Currently round-trip logical plan serialization is broken for some
aggregation queries. This happens when the `TypeCoercion` optimizer casts
literal values in aggregate function expressions and then the const evaluator
optimizes out the cast (replacing with a literal for the casted value). This
effectively changes the expression name and causes a mismatch when rebuilding
the plan after deserialization.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
In `TypeCoercion` special-case the handling of aggregation function
expressions to make sure we alias back to the original expression name if it
has changed. This should ensure the schema is still valid and the plan can be
rebuilt from its serialized representation.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
no
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
