westonpace commented on code in PR #13931:
URL: https://github.com/apache/arrow/pull/13931#discussion_r977971724
##########
cpp/src/arrow/csv/reader.cc:
##########
@@ -887,30 +872,37 @@ class StreamingReaderImpl : public ReaderMixin,
protected:
Future<> InitAfterFirstBuffer(const std::shared_ptr<Buffer>& first_buffer,
AsyncGenerator<std::shared_ptr<Buffer>>
buffer_generator,
- int max_readahead) {
+ int max_readahead, Executor* cpu_executor) {
if (first_buffer == nullptr) {
return Status::Invalid("Empty CSV file");
}
std::shared_ptr<Buffer> after_header;
- ARROW_ASSIGN_OR_RAISE(auto header_bytes_consumed,
- ProcessHeader(first_buffer, &after_header));
+ ARROW_ASSIGN_OR_RAISE(
+ auto header_bytes_consumed,
+ ReaderMixin<InputType>::ProcessHeader(first_buffer, &after_header));
bytes_decoded_->fetch_add(header_bytes_consumed);
- auto parser_op =
- BlockParsingOperator(io_context_, parse_options_, num_csv_cols_,
num_rows_seen_);
+ auto parser_op = BlockParsingOperator(
+ ReaderMixin<InputType>::io_context_,
ReaderMixin<InputType>::parse_options_,
+ ReaderMixin<InputType>::num_csv_cols_,
ReaderMixin<InputType>::num_rows_seen_);
Review Comment:
Are these sorts of changes (where you are adding `ReaderMixin<InputType>::`
needed to resolve some kind of ambiguity? I don't know that we have any
specific stance in the style guide so I'm not sure it's a problem but I'm
curious why you made the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
