askoa commented on code in PR #2782:
URL: https://github.com/apache/arrow-rs/pull/2782#discussion_r984643910
##########
object_store/src/aws/client.rs:
##########
@@ -354,7 +356,7 @@ impl S3Client {
token: Option<&str>,
) -> Result<(ListResult, Option<String>)> {
let credential = self.get_credential().await?;
- let url = format!("{}/{}", self.config.endpoint, self.config.bucket);
+ let url = self.config.bucket_endpoint.clone();
Review Comment:
This is the only url pre constructed. It does not have `key` in it. The ones
with `format!` are different compared to this.
##########
object_store/src/aws/client.rs:
##########
@@ -209,14 +209,16 @@ pub struct S3Config {
pub region: String,
pub endpoint: String,
pub bucket: String,
+ pub bucket_endpoint: String,
pub credentials: CredentialProvider,
pub retry_config: RetryConfig,
pub allow_http: bool,
+ pub virtual_hosted_request_style: bool,
Review Comment:
Will fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
