askoa commented on code in PR #2782:
URL: https://github.com/apache/arrow-rs/pull/2782#discussion_r985094707
##########
object_store/src/aws/mod.rs:
##########
@@ -541,14 +562,29 @@ impl AmazonS3Builder {
},
};
- let endpoint = self
- .endpoint
- .unwrap_or_else(|| format!("https://s3.{}.amazonaws.com";, region));
+ let endpoint: String;
+ let bucket_endpoint: String;
+
+ //If `endpoint` is provided then its assumed to be consistent with
+ // `virutal_hosted_style_request`. i.e. if
`virtual_hosted_request_style` is true then
Review Comment:
`virtual_hosted_style_request` directly comes form AWS page defining it. See
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html. I am
not inclined to make this change.
Edit: I see the problem now. I think I have to change the field name. I
think it should be `virtual_hosted_style_request` in all places. Will make that
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
