jorisvandenbossche commented on code in PR #14326:
URL: https://github.com/apache/arrow/pull/14326#discussion_r995465414
##########
cpp/src/arrow/dataset/scanner.cc:
##########
@@ -751,7 +751,19 @@ Result<ProjectionDescr>
ProjectionDescr::FromNames(std::vector<std::string> name
const Schema&
dataset_schema) {
std::vector<compute::Expression> exprs(names.size());
for (size_t i = 0; i < exprs.size(); ++i) {
- exprs[i] = compute::field_ref(names[i]);
+ // If name isn't in schema, try finding it by dotted path.
+ if (dataset_schema.GetFieldByName(names[i]) == nullptr) {
+ auto name = names[i];
+ if (name.rfind(".", 0) != 0) {
+ name = "." + name;
+ }
+ ARROW_ASSIGN_OR_RAISE(auto field_ref, FieldRef::FromDotPath(name));
+ // safe as we know there is at least 1 dot.
+ names[i] = name.substr(name.rfind(".") + 1);
+ exprs[i] = compute::field_ref(field_ref);
Review Comment:
`field_ref` is already a FieldRef, so is it needed to call the
`compute::field_ref(..)` again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
