jorisvandenbossche commented on code in PR #14326:
URL: https://github.com/apache/arrow/pull/14326#discussion_r998421185
##########
cpp/src/arrow/dataset/test_util.h:
##########
@@ -157,7 +157,7 @@ class DatasetFixtureMixin : public ::testing::Test {
std::shared_ptr<RecordBatch> lhs;
ASSERT_OK(expected->ReadNext(&lhs));
EXPECT_NE(lhs, nullptr);
- AssertBatchesEqual(*lhs, batch);
+ AssertBatchesEqual(*lhs, batch, true);
Review Comment:
This feels as a bug to me that this is needed, since that flag is about
checking schema _metadata_, not about checking the schema itself. I opened
https://issues.apache.org/jira/browse/ARROW-18087 (we can probably handle this
in a follow-up)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
