tustvold commented on PR #2883:
URL: https://github.com/apache/arrow-rs/pull/2883#issuecomment-1279884619

   > And it is obviously not guaranteed to be.
   
   It is supposed to be - 
https://arrow.apache.org/docs/format/Columnar.html#buffer-alignment-and-padding 
by ensuring the buffers are padded correctly, we can ensure that correctly 
aligning the entire memory allocation is sufficient to align the child 
allocations. When the writer has not done this correctly, we will have to copy 
the buffers
   
   > The alignment soundness in PrimitiveArray::values is guaranteed by 
is_aligned_and_not_null.
   
   Where is this called, I think I am being blind. It looks like this PR 
removes the alignment check in PrimitiveArray?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to