tustvold commented on PR #2883: URL: https://github.com/apache/arrow-rs/pull/2883#issuecomment-1279890454
> It sounds like it can be any alignment larger than 8 bytes. Correct > Maybe we can change to 16 bytes alignment? For buffers we allocate we use larger alignments (32 bytes on arm, 128 bytes on x86) - see https://github.com/apache/arrow-rs/blob/master/arrow-buffer/src/alloc/alignment.rs The issue is whatever wrote the test file in the ticket was only using the minimum 8 byte padding, and so we need to copy in such cases > Hmm, for now this sounds like a special case (DecimalArray + arm) I think it will also impact IntervalMonthDayNanoType which also uses i128 > I'm okay for the copying approach TBC we should only copy as a fallback for when the buffer is not sufficiently aligned. We could probably do this in the general case, it is better than panicking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
