milesgranger commented on code in PR #14326:
URL: https://github.com/apache/arrow/pull/14326#discussion_r998291679
##########
cpp/src/arrow/dataset/scanner_test.cc:
##########
@@ -1074,6 +1074,24 @@ TEST_P(TestScanner, ProjectedScanNested) {
AssertScanBatchesUnorderedEqualRepetitionsOf(MakeScanner(batch_in),
batch_out);
}
+TEST_P(TestScanner, ProjectedScanNestedFromNames) {
+ SetSchema({
+ field("struct", struct_({field("i32", int32()), field("f64",
float64())})),
+ field("nested", struct_({field("left", int32()),
+ field("right", struct_({field("i32", int32()),
+ field("f64",
float64())}))})),
+ });
+ ASSERT_OK_AND_ASSIGN(auto descr,
+ ProjectionDescr::FromNames({"struct.i32",
"nested.right.f64"},
+ *options_->dataset_schema))
+ SetProjection(options_.get(), std::move(descr));
+ auto batch_in = ConstantArrayGenerator::Zeroes(GetParam().items_per_batch,
schema_);
+ auto batch_out = ConstantArrayGenerator::Zeroes(
+ GetParam().items_per_batch,
+ schema({field("struct.i32", int32()), field("nested.right.f64",
float64())}));
Review Comment:
Found and fixed in
https://github.com/apache/arrow/pull/14326/commits/ae5b01d2ce7c67fba5fc17028e6230fb550d2535,
verified it'll fail with different field names. All other tests continued to
pass locally, so didn't bother to propagate the `check_metadata` parameter up
further from `AssertBatchEquals`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
