alamb commented on code in PR #3987:
URL: https://github.com/apache/arrow-datafusion/pull/3987#discussion_r1007327438
##########
datafusion/proto/Cargo.toml:
##########
@@ -55,5 +55,6 @@ doc-comment = "0.3"
tokio = "1.18"
[build-dependencies]
-pbjson-build = { version = "0.5" }
-prost-build = { version = "0.11.1" }
+# Pin these dependencies so that the generated output is deterministic
+pbjson-build = { version = "=0.5.1" }
Review Comment:
Right -- I guess I was saying with this approach we won't see 0.5.2 if it is
released.
If we left
```
pbjson-build = { version = "0.5.1" }
```
We would start seeing local changes in our checkouts again potentially which
might prompt someone to check them in?
I don't feel strongly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
