assignUser commented on code in PR #14596: URL: https://github.com/apache/arrow/pull/14596#discussion_r1015560425
########## ci/docker/conda-python-substrait.dockerfile: ########## @@ -0,0 +1,35 @@ +ARG repo +ARG arch +ARG python=3.9 + +FROM ${repo}:${arch}-conda-python-${python} + +COPY ci/conda_env_python.txt \ + ci/conda_env_sphinx.txt \ + /arrow/ci/ +RUN mamba install -q -y \ + --file arrow/ci/conda_env_python.txt \ + --file arrow/ci/conda_env_sphinx.txt \ + $([ "$python" == "3.7" ] && echo "pickle5") \ + python=${python} \ + nomkl && \ + mamba clean --all + +# XXX The GCS testbench was already installed in conda-cpp.dockerfile, +# but we changed the installed Python version above, so we need to reinstall it. +COPY ci/scripts/install_gcs_testbench.sh /arrow/ci/scripts +RUN /arrow/ci/scripts/install_gcs_testbench.sh default Review Comment: I think this should not be necessary as we have a `conda-python` image for each python version, so GCS would have been installed with the same version as `ARG python`. ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org