timvw commented on code in PR #4227:
URL: https://github.com/apache/arrow-datafusion/pull/4227#discussion_r1023566499
##########
datafusion/core/src/execution/runtime_env.rs:
##########
@@ -152,7 +153,16 @@ pub struct RuntimeConfig {
impl RuntimeConfig {
/// New with default values
pub fn new() -> Self {
- Default::default()
+ let mut table_factories: HashMap<String, Arc<dyn
TableProviderFactory>> =
+ HashMap::new();
+ table_factories.insert("PARQUET".into(),
Arc::new(ListingTableFactory::new()));
+ table_factories.insert("CSV".into(),
Arc::new(ListingTableFactory::new()));
+ table_factories.insert("JSON".into(),
Arc::new(ListingTableFactory::new()));
Review Comment:
> do we need to add an entry for "NDJSON" as well? See #4198
This would be possible, but currently (logical/datasource)
FileType::from_str only knows about avro,parquet,json and csv and will err.. So
more changes will be needed to enable NDJSON again..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
