alamb commented on code in PR #4227:
URL: https://github.com/apache/arrow-datafusion/pull/4227#discussion_r1025261843
##########
datafusion-cli/src/main.rs:
##########
@@ -147,31 +143,11 @@ pub async fn main() -> Result<()> {
}
fn create_runtime_env() -> Result<RuntimeEnv> {
- let mut table_factories: HashMap<String, Arc<dyn TableProviderFactory>> =
- HashMap::new();
- table_factories.insert(
- "csv".to_string(),
- Arc::new(ListingTableFactory::new(FileType::CSV)),
- );
- table_factories.insert(
- "parquet".to_string(),
- Arc::new(ListingTableFactory::new(FileType::PARQUET)),
- );
- table_factories.insert(
- "avro".to_string(),
- Arc::new(ListingTableFactory::new(FileType::AVRO)),
- );
- table_factories.insert(
- "json".to_string(),
- Arc::new(ListingTableFactory::new(FileType::JSON)),
- );
-
let object_store_provider = DatafusionCliObjectStoreProvider {};
let object_store_registry =
ObjectStoreRegistry::new_with_provider(Some(Arc::new(object_store_provider)));
let rn_config = RuntimeConfig::new()
- .with_object_store_registry(Arc::new(object_store_registry))
- .with_table_factories(table_factories);
+ .with_object_store_registry(Arc::new(object_store_registry));
Review Comment:
❤️
##########
datafusion/core/src/catalog/listing_schema.rs:
##########
@@ -59,18 +61,24 @@ impl ListingSchemaProvider {
/// `path`: The root path that contains subfolders which represent tables
/// `factory`: The `TableProviderFactory` to use to instantiate tables for
each subfolder
/// `store`: The `ObjectStore` containing the table data
+ /// `format`: The `FileFormat` of the tables
Review Comment:
I am not sure it matters, but this says `FileFormat` but the actual argument
is a String
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
