alamb commented on PR #4261: URL: https://github.com/apache/arrow-datafusion/pull/4261#issuecomment-1322404775
> Will we keep using as_xxx_array scheme but implement these function with downcast_value? Isn't it cause code duplication? All functions will have downcast_value!(values, ArrayType) only ArrayType will change. I think that is fine (or maybe we can remove duplication by creating a macro that creates the entire function `as_binary_array` -- like `make_downcast_vaue()` It would be good to eventually remove all uses of `downcast_value!` in favor of the `as_xxx_array` functions so there is single way to do this downcasting (which is the overall goal of https://github.com/apache/arrow-datafusion/issues/3152 -- to have single way in the codebase to do it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
