retikulum commented on code in PR #4261:
URL: https://github.com/apache/arrow-datafusion/pull/4261#discussion_r1026636116
##########
datafusion/common/src/cast.rs:
##########
@@ -116,3 +116,36 @@ pub fn as_string_array(array: &dyn Array) ->
Result<&StringArray, DataFusionErro
))
})
}
+
+// Downcast ArrayRef to UInt32Array
+pub fn as_uint32_array(array: &dyn Array) -> Result<&UInt32Array,
DataFusionError> {
+ array.as_any().downcast_ref::<UInt32Array>().ok_or_else(|| {
+ DataFusionError::Internal(format!(
+ "Expected a UInt32Array, got: {}",
+ array.data_type()
+ ))
+ })
+}
+
+// Downcast ArrayRef to UInt64Array
+pub fn as_uint64_array(array: &dyn Array) -> Result<&UInt64Array,
DataFusionError> {
+ array.as_any().downcast_ref::<UInt64Array>().ok_or_else(|| {
+ DataFusionError::Internal(format!(
+ "Expected a UInt64Array, got: {}",
+ array.data_type()
+ ))
+ })
+}
+
+// Downcast ArrayRef to BooleanArray
+pub fn as_boolean_array(array: &dyn Array) -> Result<&BooleanArray,
DataFusionError> {
+ array
+ .as_any()
+ .downcast_ref::<BooleanArray>()
+ .ok_or_else(|| {
+ DataFusionError::Internal(format!(
+ "Expected a BooleanArray, got: {}",
+ array.data_type()
+ ))
+ })
+}
Review Comment:
Thanks for the feedback. I just didn't know about this macro. If you feel
that this is wrong or not good aesthetically, I will refactor previous PRs with
`downcast_value` macro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
