viirya commented on code in PR #3155:
URL: https://github.com/apache/arrow-rs/pull/3155#discussion_r1031315171
##########
arrow-array/src/builder/buffer_builder.rs:
##########
@@ -21,47 +21,78 @@ use std::marker::PhantomData;
use crate::types::*;
+/// A signed 8-bit integer buffer builder.
pub type Int8BufferBuilder = BufferBuilder<i8>;
+/// A signed 16-bit integer buffer builder.
pub type Int16BufferBuilder = BufferBuilder<i16>;
+/// A signed 32-bit integer buffer builder.
pub type Int32BufferBuilder = BufferBuilder<i32>;
+/// A signed 64-bit integer buffer builder.
pub type Int64BufferBuilder = BufferBuilder<i64>;
+/// An usigned 8-bit integer buffer builder.
pub type UInt8BufferBuilder = BufferBuilder<u8>;
+/// An usigned 16-bit integer buffer builder.
pub type UInt16BufferBuilder = BufferBuilder<u16>;
+/// An usigned 32-bit integer buffer builder.
pub type UInt32BufferBuilder = BufferBuilder<u32>;
+/// An usigned 64-bit integer buffer builder.
pub type UInt64BufferBuilder = BufferBuilder<u64>;
+/// A 32-bit floating point buffer builder.
pub type Float32BufferBuilder = BufferBuilder<f32>;
+/// A 64-bit floating point buffer builder.
pub type Float64BufferBuilder = BufferBuilder<f64>;
+/// A timestamp second array builder.
pub type TimestampSecondBufferBuilder =
BufferBuilder<<TimestampSecondType as ArrowPrimitiveType>::Native>;
+/// A timestamp millisecond array builder.
pub type TimestampMillisecondBufferBuilder =
BufferBuilder<<TimestampMillisecondType as ArrowPrimitiveType>::Native>;
+/// A timestamp microsecond array builder.
pub type TimestampMicrosecondBufferBuilder =
BufferBuilder<<TimestampMicrosecondType as ArrowPrimitiveType>::Native>;
+/// A timestamp nanosecond array builder.
pub type TimestampNanosecondBufferBuilder =
BufferBuilder<<TimestampNanosecondType as ArrowPrimitiveType>::Native>;
+
+/// A 32-bit date array builder.
Review Comment:
```suggestion
/// Buffer builder for 32-bit date type
```
##########
arrow-array/src/builder/buffer_builder.rs:
##########
@@ -21,47 +21,78 @@ use std::marker::PhantomData;
use crate::types::*;
+/// A signed 8-bit integer buffer builder.
pub type Int8BufferBuilder = BufferBuilder<i8>;
+/// A signed 16-bit integer buffer builder.
pub type Int16BufferBuilder = BufferBuilder<i16>;
+/// A signed 32-bit integer buffer builder.
pub type Int32BufferBuilder = BufferBuilder<i32>;
+/// A signed 64-bit integer buffer builder.
pub type Int64BufferBuilder = BufferBuilder<i64>;
+/// An usigned 8-bit integer buffer builder.
pub type UInt8BufferBuilder = BufferBuilder<u8>;
+/// An usigned 16-bit integer buffer builder.
pub type UInt16BufferBuilder = BufferBuilder<u16>;
+/// An usigned 32-bit integer buffer builder.
pub type UInt32BufferBuilder = BufferBuilder<u32>;
+/// An usigned 64-bit integer buffer builder.
pub type UInt64BufferBuilder = BufferBuilder<u64>;
+/// A 32-bit floating point buffer builder.
pub type Float32BufferBuilder = BufferBuilder<f32>;
+/// A 64-bit floating point buffer builder.
pub type Float64BufferBuilder = BufferBuilder<f64>;
+/// A timestamp second array builder.
Review Comment:
```suggestion
/// Buffer builder for timestamp type of second unit.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
