viirya commented on code in PR #3155:
URL: https://github.com/apache/arrow-rs/pull/3155#discussion_r1031329844
##########
arrow-array/src/builder/map_builder.rs:
##########
@@ -32,10 +59,14 @@ pub struct MapBuilder<K: ArrayBuilder, V: ArrayBuilder> {
value_builder: V,
}
+/// Contains details of the mapping
#[derive(Debug, Clone)]
pub struct MapFieldNames {
+ /// [`Field`] name for map
pub entry: String,
+ /// [`Field`] name for key
Review Comment:
```suggestion
/// [`Field`] name for map key
```
##########
arrow-array/src/builder/map_builder.rs:
##########
@@ -32,10 +59,14 @@ pub struct MapBuilder<K: ArrayBuilder, V: ArrayBuilder> {
value_builder: V,
}
+/// Contains details of the mapping
#[derive(Debug, Clone)]
pub struct MapFieldNames {
+ /// [`Field`] name for map
pub entry: String,
+ /// [`Field`] name for key
pub key: String,
+ /// [`Field`] name for value
Review Comment:
```suggestion
/// [`Field`] name for map value
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
