liukun4515 commented on issue #4389: URL: https://github.com/apache/arrow-datafusion/issues/4389#issuecomment-1331621205
ðŸ˜, I also confused about we split the join to `join` and `crossjoin` in the logical phase, I think we can combine these two together and just add `crossjoin` join_type for this. This is a historical issue and don't know when the datafusion add the `cross join` in the logical plan. I think it's necessary to refactor this to combine them together in the logical phase, but it will bring a `api break changes` in the `logical.proto`. @andygrove @alamb @Dandandan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
