liukun4515 commented on issue #4389: URL: https://github.com/apache/arrow-datafusion/issues/4389#issuecomment-1331912450
> > If we can change the pub on: Vec<(column,column)> to option, we don't need to do the #4353 specifically for the expr in the Join plan. > > Thank you @liukun4515. Avoid adding type coercion specifically for join makes sense to me, but we need split the expression to join keys every time we use it, this is a regular operation in optimizer. > > Another way to avoid adding the special type coercion, is: > > * Still use `Vec<(Expr, Expr)>` in `LogicalPlan::Join`. > * Combine the left and right join key to `equality expression` in `logical_plan.expressions()`. > * Split the casted equality expression to left and right join key in `from_plan` when doing type coercion. > > I'm not sure if this way will change a lot, so need some tries. ``` Combine the left and right join key to equality expression in logical_plan.expressions() ``` It's a smooth method to make consistent with other logic, we can try it. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
