jorgecarleitao commented on a change in pull request #8485:
URL: https://github.com/apache/arrow/pull/8485#discussion_r507072431
##########
File path: rust/arrow/src/array/equal.rs
##########
@@ -43,11 +43,15 @@ pub trait ArrayEqual {
}
impl<T: ArrowPrimitiveType> ArrayEqual for PrimitiveArray<T> {
- default fn equals(&self, other: &dyn Array) -> bool {
+ fn equals(&self, other: &dyn Array) -> bool {
if !base_equal(&self.data(), &other.data()) {
return false;
}
+ if T::DATA_TYPE == DataType::Boolean {
Review comment:
Here we use the same principle: this will be a constant `if a == a` or
`if a == b`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
