jorgecarleitao commented on a change in pull request #8485:
URL: https://github.com/apache/arrow/pull/8485#discussion_r507072708
##########
File path: rust/arrow/src/compute/kernels/filter.rs
##########
@@ -424,7 +424,7 @@ impl FilterContext {
where
T: ArrowNumericType,
{
- let array_type = T::get_data_type();
+ let array_type = T::DATA_TYPE;
Review comment:
this could actually be removed by making `filter_array_impl` a generic
over `T`. I left for a future exercise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
