alamb commented on code in PR #3252:
URL: https://github.com/apache/arrow-rs/pull/3252#discussion_r1037434583
##########
object_store/src/aws/mod.rs:
##########
@@ -670,11 +669,10 @@ impl AmazonS3Builder {
bucket_endpoint,
credentials,
retry_config: self.retry_config,
- allow_http: self.allow_http,
- proxy_url: self.proxy_url,
+ client_options: self.client_options,
};
- let client = Arc::new(S3Client::new(config).unwrap());
+ let client = Arc::new(S3Client::new(config)?);
Review Comment:
👍
##########
object_store/src/client/mod.rs:
##########
@@ -23,3 +23,53 @@ pub mod mock_server;
pub mod pagination;
pub mod retry;
pub mod token;
+
+use reqwest::{Client, ClientBuilder, Proxy};
+
+fn map_client_error(e: reqwest::Error) -> super::Error {
+ super::Error::Generic {
+ store: "client",
Review Comment:
Should we make it more specific (like `client(reqwests)`) I wonder 🤔 to make
it clear it is the http client (as opposed to the object store client or
various other clients it might be)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
