alamb opened a new pull request, #4492: URL: https://github.com/apache/arrow-datafusion/pull/4492
# Which issue does this PR close? Towards https://github.com/apache/arrow-datafusion/issues/3887 Also re https://github.com/apache/arrow-datafusion/issues/4349 # Rationale for this change see https://github.com/apache/arrow-datafusion/issues/3887 TLDR is 1. A single way to do configuration options in ConfigOptions makes the code cleaner 2. Using ConfigOptions makes them easier to find (as they are documented) 3. Using ConfigOptions makes these settings dynamically configurable (via environment variable or `SET <variable>` syntax # What changes are included in this PR? Move all `SessionConfig` settings other than the schema / catalog names into the `ConfigOptions` structure, # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? Some fields that were `pub` not must be set via a `with_` method or accessed via an accessor. The number of locations in the DataFusion codebase was quite low, which was a nice surprise to me The mix of HashMap / rust struct style / builder styles is somewhat of a bummer. I bet some fancy macro magic could unify the two but I don't know the right incantations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
