alamb opened a new pull request, #4578: URL: https://github.com/apache/arrow-datafusion/pull/4578
# Which issue does this PR close? re https://github.com/apache/arrow-datafusion/issues/4460 # Rationale for this change A follow up from https://github.com/apache/arrow-datafusion/pull/4547 which parsed CSV writer output After https://github.com/apache/arrow-datafusion/pull/4547, the sqllogictest code writes RecordBatches to csv and then reparses it. This can lead to misleading results if the data had ' ' in it, for example. # What changes are included in this PR? 1. Generate `Vec<Vec<String>>` directly 2. Use `arrow::util::display` for string display rather than the writer. This is what `pretty_format_batches` uses underneath so should be more consistent with existing tests 3. Check that all output RecordBatches have the same schema # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 4. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
