tustvold commented on code in PR #3333:
URL: https://github.com/apache/arrow-rs/pull/3333#discussion_r1045978237
##########
parquet/src/bloom_filter/mod.rs:
##########
@@ -194,14 +238,14 @@ impl Sbbf {
/// Write the bitset in serialized form to the writer.
fn write_bitset<W: Write>(&self, mut writer: W) -> Result<(),
ParquetError> {
for block in &self.0 {
Review Comment:
I also experimented with transmuting the entire `Vec<Block>` this did lead
to a very slight additional speed boost of 2%, but I didn't think it justified
its unsafe-ness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
