jonmmease commented on code in PR #3473:
URL: https://github.com/apache/arrow-rs/pull/3473#discussion_r1063343088
##########
arrow-select/src/take.rs:
##########
@@ -1519,12 +1524,12 @@ mod tests {
macro_rules! test_take_list {
($offset_type:ty, $list_data_type:ident, $list_array_type:ident) => {{
- // Construct a value array, [[0,0,0], [-1,-2,-1], [2,3]]
+ // Construct a value array, [[0,0,0], [-1,-2,-1], [], [2,3]]
Review Comment:
This test was updated to add an extra empty array element and to make sure
it's preserved in the output of take
##########
arrow-select/src/take.rs:
##########
@@ -1609,7 +1612,7 @@ mod tests {
let list_data = ArrayData::builder(list_data_type.clone())
.len(4)
.add_buffer(value_offsets)
- .null_bit_buffer(Some(Buffer::from([0b10111101, 0b00000000])))
+ .null_bit_buffer(Some(Buffer::from([0b11111111])))
Review Comment:
These intended array here is `[[0,null,0], [-1,-2,3], [null], [5,null]]`,
which has no null elements in the outer list array.
##########
arrow-select/src/take.rs:
##########
@@ -1682,7 +1685,7 @@ mod tests {
let list_data = ArrayData::builder(list_data_type.clone())
.len(4)
.add_buffer(value_offsets)
- .null_bit_buffer(Some(Buffer::from([0b01111101])))
+ .null_bit_buffer(Some(Buffer::from([0b11111011])))
Review Comment:
The intended array here is `[[0,null,0], [-1,-2,3], null, [5,null]]`, where
only the third element is `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
