westonpace commented on issue #33616:
URL: https://github.com/apache/arrow/issues/33616#issuecomment-1379467218

   I'm pretty sure the reason this happens is that Acero's aggregate node 
outputs in `agg1, ..., aggN, key1, ..., keyN` order and the Substrait aggregate 
node expects output in `key1, ..., keyN, agg1, ..., aggN` order.
   
   We could change the aggregate node but this would be a breaking change for 
things like `pyarrow.group_by` (admittedly, it may be a welcome change).  
@jorisvandenbossche 
   
   If we want to avoid the breaking change then we could patch this in the emit 
step.  This is very similar to a problem faced by the asof join node which is 
being addressed in https://github.com/apache/arrow/pull/14799 or the solution 
that we used for project where we provided a specialization of ProcessEmitInfo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to