raulcd commented on code in PR #14533:
URL: https://github.com/apache/arrow/pull/14533#discussion_r1068489797
##########
dev/merge_arrow_pr.py:
##########
@@ -278,8 +299,11 @@ def show(self):
def get_candidate_fix_version(mainline_versions,
- merge_branches=('master',),
+ merge_branches=None,
maintenance_branches=()):
+ if merge_branches is None:
+ merge_branches = (git_default_branch_name(),)
Review Comment:
Thanks @lafiona for the changes! Only one more thing, now `merge_branches`
is never used, we can get rid of it and we can also get rid of the new function
created to retrieve the `git_default_branch_name` because the script is never
calling that function once we remove `merge_branches`. That makes sense as we
use the GitHub API to merge the PR and we use the base branch defined on the
PR, not the one on this script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
