Bei-z commented on a change in pull request #8542:
URL: https://github.com/apache/arrow/pull/8542#discussion_r517700007
##########
File path: cpp/src/arrow/util/basic_decimal.cc
##########
@@ -395,6 +395,31 @@ BasicDecimal128& BasicDecimal128::operator*=(const
BasicDecimal128& right) {
return *this;
}
+/// Expands the given big endian array of uint64_t into an array of uint32_t.
+/// The value of input array is expected to be positive. The result_array will
Review comment:
Done. Thank you!
##########
File path: cpp/src/arrow/util/basic_decimal.cc
##########
@@ -451,6 +463,27 @@ static int64_t FillInArray(const BasicDecimal128& value,
uint32_t* array,
return 1;
}
+/// Expands the given value into an array of ints so that we can work on
+/// it. The array will be converted to an absolute value and the wasNegative
Review comment:
Done. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
