emkornfield commented on a change in pull request #8589:
URL: https://github.com/apache/arrow/pull/8589#discussion_r518528887
##########
File path: cpp/src/parquet/column_writer.cc
##########
@@ -1230,8 +1230,9 @@ class TypedColumnWriterImpl : public ColumnWriterImpl,
public TypedColumnWriter<
buffers[0] = bits_buffer_;
// Should be a leaf array.
DCHECK_EQ(array->num_fields(), 0);
- return arrow::MakeArray(std::make_shared<ArrayData>(
- array->type(), array->length(), std::move(buffers), new_null_count));
+ return arrow::MakeArray(std::make_shared<ArrayData>(array->type(),
array->length(),
+ std::move(buffers),
Review comment:
yeah, I'm not sure I like that change that way, I'll try to make a new
commit on your branch with something that I think will be cleaner (adding an
API to Array to get the right sliced buffer.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
