crepererum commented on PR #4924: URL: https://github.com/apache/arrow-datafusion/pull/4924#issuecomment-1385452609
> > Can we have a benchmark run for this? Basically run `cargo bench -p datafusion --bench aggregate_query_sql -- --save-baseline pr4924-pre` before your first commit and `cargo bench -p datafusion --bench aggregate_query_sql -- --baseline pr4924-pre` after your last one and post the result of the latter. > > I updated PR body to include benchmark result(against master branch). Thanks for pointing this out. Looks good, mostly noise I guess (and even if we suffer a 10% hit, I would take that for the simpler implementation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
