tustvold commented on code in PR #4999: URL: https://github.com/apache/arrow-datafusion/pull/4999#discussion_r1082332500
########## datafusion/core/tests/path_partition.rs: ########## @@ -204,7 +204,7 @@ async fn csv_filter_with_file_col() -> Result<()> { ); let result = ctx - .sql("SELECT c1, c2 FROM t WHERE date='2021-10-27' and date!=c1 LIMIT 5") + .sql("SELECT c1, c2 FROM t WHERE date='2021-10-27' and c1!='2021-10-27' LIMIT 5") Review Comment: I couldn't see a compelling reason why this test needed to test comparison of dictionary columns -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org