jorgecarleitao edited a comment on pull request #8645:
URL: https://github.com/apache/arrow/pull/8645#issuecomment-725910876


   @alamb @jhorstmann @vertexclique , I think I need your help here. This 
change is causing a segfault in one of the benchmarks, even though I have not 
changed any unsafe code and think the change is reasonable.
   
   I narrowed it down to the function `set_bits_raw`. I think that this 
function is accessing a byte too many. However, my bit knowledge is limited 
here. I filled ARROW-10562 with why I think the function has an issue. IMO the 
reason this has not surfaced before is that we were allocating too much memory 
in the boolean buffers, and thus the memory address was fine.
   
   (IMO we should just make that thing safe...)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to