jhorstmann commented on a change in pull request #8645:
URL: https://github.com/apache/arrow/pull/8645#discussion_r522016134
##########
File path: rust/arrow/src/array/builder.rs
##########
@@ -525,7 +515,7 @@ impl<T: ArrowPrimitiveType> ArrayBuilder for
PrimitiveBuilder<T> {
let sliced = array.buffers()[0].data();
// slice into data by factoring (offset and length) * byte
width
self.values_builder
- .write_bytes(&sliced[(offset * mul)..((len + offset) *
mul)], len)?;
+ .write_bytes(&sliced[(offset * mul)..((len + offset) *
mul)], len);
Review comment:
I couldn't reproduce the issue yet, but this line looks a bit
suspicious. The first parameter has a larger len (in bytes) than the second
`len` parameter indicates (number of `T` elements).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
