wjones127 commented on code in PR #417:
URL: https://github.com/apache/arrow-adbc/pull/417#discussion_r1099002368


##########
adbc.h:
##########
@@ -903,12 +904,10 @@ AdbcStatusCode AdbcConnectionGetInfo(struct 
AdbcConnection* connection,
 /// \param[out] out The result set.
 /// \param[out] error Error details, if an error occurs.
 ADBC_EXPORT
-AdbcStatusCode AdbcConnectionGetObjects(struct AdbcConnection* connection, int 
depth,
-                                        const char* catalog, const char* 
db_schema,
-                                        const char* table_name, const char** 
table_type,
-                                        const char* column_name,
-                                        struct ArrowArrayStream* out,
-                                        struct AdbcError* error);
+AdbcStatusCode AdbcConnectionGetObjects(
+    struct AdbcConnection* connection, int depth, const char* catalog,
+    const char* db_schema, const char* table_name, char const* const* 
table_type,

Review Comment:
   This might be one where I leave as is in the header but keep this change in 
the Rust FFI definitions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to