[GitHub] [arrow-adbc] wjones127 commented on a diff in pull request #417: format(api!): clarify const-ness of some pointers

[via GitHub]

wjones127 commented on code in PR #417:
URL: https://github.com/apache/arrow-adbc/pull/417#discussion_r1099032262


##########
adbc.h:
##########
@@ -624,18 +624,18 @@ struct ADBC_EXPORT AdbcDriver {
   AdbcStatusCode (*DatabaseRelease)(struct AdbcDatabase*, struct AdbcError*);
 
   AdbcStatusCode (*ConnectionCommit)(struct AdbcConnection*, struct 
AdbcError*);
-  AdbcStatusCode (*ConnectionGetInfo)(struct AdbcConnection*, uint32_t*, 
size_t,
+  AdbcStatusCode (*ConnectionGetInfo)(struct AdbcConnection*, const uint32_t*, 
size_t,
                                       struct ArrowArrayStream*, struct 
AdbcError*);
   AdbcStatusCode (*ConnectionGetObjects)(struct AdbcConnection*, int, const 
char*,
-                                         const char*, const char*, const 
char**,
+                                         const char*, const char*, char const* 
const*,
                                          const char*, struct ArrowArrayStream*,
                                          struct AdbcError*);
   AdbcStatusCode (*ConnectionGetTableSchema)(struct AdbcConnection*, const 
char*,
                                              const char*, const char*,
                                              struct ArrowSchema*, struct 
AdbcError*);
   AdbcStatusCode (*ConnectionGetTableTypes)(struct AdbcConnection*,
                                             struct ArrowArrayStream*, struct 
AdbcError*);
-  AdbcStatusCode (*ConnectionInit)(struct AdbcConnection*, struct 
AdbcDatabase*,
+  AdbcStatusCode (*ConnectionInit)(struct AdbcConnection*, struct AdbcDatabase 
const*,
                                    struct AdbcError*);
   AdbcStatusCode (*ConnectionNew)(struct AdbcConnection*, struct AdbcError*);

Review Comment:
   Okay I've updated the doc string on each of those. LMK what you think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org