kou commented on code in PR #34054:
URL: https://github.com/apache/arrow/pull/34054#discussion_r1117615202
##########
cpp/src/parquet/statistics.cc:
##########
@@ -494,6 +494,8 @@ class TypedStatisticsImpl : public TypedStatistics<DType> {
int64_t null_count, int64_t distinct_count, bool
has_min_max,
bool has_null_count, bool has_distinct_count,
MemoryPool* pool)
: TypedStatisticsImpl(descr, pool) {
+ has_null_count_ = has_null_count;
+ has_distinct_count_ = has_distinct_count;
Review Comment:
It seems that this is a correct change.
How about adding tests related to this to
`cpp/src/parquet/statistics_test.cc` or spliting this to another pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
