Dandandan commented on PR #5408: URL: https://github.com/apache/arrow-datafusion/pull/5408#issuecomment-1447760368
> @Dandandan, I reviewed the failed test and identified the root cause of the issue. It appears that the problem occurred because there was a modification made to the structure of the `DistinctScalarValues` from `DistinctScalarValues(Vec<ScalarValue>)` to `DistinctScalarValues(ScalarValue)`. This change caused the test to fail because the test was designed to work with two different types of data. > > https://github.com/apache/arrow-datafusion/blob/16cb4c122f8ea110bc7adf425f4905fa06ed2c81/datafusion/physical-expr/src/aggregate/count_distinct.rs#L608-L642 Ok. I think we have to update (or remove) the tests to update the expectations that we no longer support multiple columns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
