Dandandan commented on code in PR #5408:
URL: https://github.com/apache/arrow-datafusion/pull/5408#discussion_r1118568461
##########
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##########
@@ -205,6 +146,52 @@ impl Accumulator for DistinctCountAccumulator {
Ok(cols_out.into_iter().collect())
}
+ fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
+ if values.is_empty() {
+ return Ok(());
+ }
+ let arr = &values[0];
+ (0..arr.len()).try_for_each(|index| {
+ let scalar = ScalarValue::try_from_array(arr, index)?;
+ let scalar = vec![scalar];
Review Comment:
We can modify `DistinctScalarValues` from
`struct DistinctScalarValues(Vec<ScalarValue>)`
to
`struct DistinctScalarValues(ScalarValue)`
and update the code accordingly.
This might provide some small performance increase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
