icexelloss commented on code in PR #34311:
URL: https://github.com/apache/arrow/pull/34311#discussion_r1127016093
##########
cpp/src/arrow/compute/row/grouper.h:
##########
@@ -39,10 +108,19 @@ class ARROW_EXPORT Grouper {
static Result<std::unique_ptr<Grouper>> Make(const std::vector<TypeHolder>&
key_types,
ExecContext* ctx =
default_exec_context());
- /// Consume a batch of keys, producing the corresponding group ids as an
integer array.
+ /// Consume a batch of keys, producing the corresponding group ids as an
integer array,
+ /// over a slice defined by an offset and length, which defaults to the
batch length.
+ /// Currently only uint32 indices will be produced, eventually the bit width
will only
+ /// be as wide as necessary.
+ virtual Result<Datum> Consume(const ExecSpan& batch, int64_t offset = 0,
+ int64_t length = -1) = 0;
+
+ /// Consume a batch of keys, producing the corresponding group ids as an
integer array,
+ /// over a slice defined by an offset and length, which defaults to the
batch length.
/// Currently only uint32 indices will be produced, eventually the bit width
will only
/// be as wide as necessary.
- virtual Result<Datum> Consume(const ExecSpan& batch) = 0;
+ virtual Result<Datum> Consume(const ExecBatch& batch, int64_t offset = 0,
Review Comment:
Do we still need this or can we remove the ExecBatch version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
