lidavidm commented on code in PR #34476:
URL: https://github.com/apache/arrow/pull/34476#discussion_r1127820248
##########
go/arrow/ipc/ipc.go:
##########
@@ -168,6 +169,26 @@ func WithDictionaryDeltas(v bool) Option {
}
}
+// WithMinSpaceSavings specifies a percentage of space savings for
+// compression to be applied to buffers.
+//
+// Space savings is calculated as (1.0 - compressedSize / uncompressedSize).
+//
+// For example, if minSpaceSavings = 0.1, a 100-byte body buffer won't
+// undergo compression if its expected compressed size exceeds 90 bytes.
+// If this option is unset, compression will be used indiscriminately. If
+// no codec was supplied, this option is ignored.
+//
+// Values outside of the range [0,1] are handled as errors.
+//
+// Note that enabling this option may result in unreadable data for Arrow
+// C++ versions prior to 12.0.0.
Review Comment:
Doesn't this also apply to go? (Or else, why did we have problems in the
integration test if this only affected C++ readers?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
