jorgecarleitao commented on a change in pull request #8738:
URL: https://github.com/apache/arrow/pull/8738#discussion_r528321569
##########
File path: rust/datafusion/src/execution/dataframe_impl.rs
##########
@@ -113,12 +113,7 @@ impl DataFrame for DataFrameImpl {
right_cols: &[&str],
) -> Result<Arc<dyn DataFrame>> {
let plan = LogicalPlanBuilder::from(&self.plan)
- .join(
- Arc::new(right.to_logical_plan()),
- join_type,
- left_cols,
- right_cols,
- )?
+ .join(&right.to_logical_plan(), join_type, left_cols, right_cols)?
Review comment:
this is unrelated: it is just a small simplification to the signature of
`LogicalPlanBuilder::join` to not require the `Arc`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
