andygrove commented on code in PR #5653:
URL: https://github.com/apache/arrow-datafusion/pull/5653#discussion_r1144001450
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -740,6 +804,47 @@ pub async fn from_substrait_rex(
"Cast experssion without output type is not
allowed".to_string(),
)),
},
+ Some(RexType::WindowFunction(window)) => {
+ let fun = match extensions.get(&window.function_reference) {
+ Some(function_name) => Ok(find_df_window_func(function_name)),
Review Comment:
Should we return an error if `find_df_window_func` returns `None` here? We
`unwrap` this later on currently, which could fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
