comphead commented on code in PR #5692:
URL: https://github.com/apache/arrow-datafusion/pull/5692#discussion_r1145029761
##########
datafusion/proto/src/logical_plan/mod.rs:
##########
@@ -2386,6 +2386,15 @@ mod roundtrip_tests {
roundtrip_expr_test(test_expr, ctx);
}
+ #[test]
Review Comment:
sorry @thinkharderdev , I mean positive test case.
ideally to have test case for valid cast and for invalid as currently in PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
